Janitorial status?

[Dimitrie O. Paun]

On April 8, 2003 08:54 am, Hans Leidekker wrote:
> Hi,
>
> I was looking for a way to kill some time when I ended up on (WineHQ's
> version of) Dimi's janitorial page. It seems the page could use an
> update since as of this moment some of the items seem to have been
> finished, or nearly so:

The one on my site is a bit more up to date:
    http://www.dssd.ca/wine/Wine-Janitorial.html

I will try to update the WineHQ one on a regular basis, but the latest
and greatest will always be on my site. For this reason, please send
updates for this page to me against my version, and I'll merge them
upstream.

As for the status, the page should be fairly up to date. I have tried
to maintain it daily, if you notice than things are no longer current,
please let me know.

> tools/winapi_check/winapi_check --none --progress --cross-call-win32-win16
>
> [...]
> loader/module.c: kernel32: WIN32_GetProcAddress16: illegal call to
> GetProcAddress16 (Win32 -> Win16) scheduler/syslevel.c: kernel32:
> _KERNEL32_86: illegal call to _LeaveSysLevel (Win32 -> Win16) [...]
>
> There must have been some problem converting these? Or were they introduced
> after the cleanup maybe? I decided to look further:

These ones seem fishy -- remember, wineapi_check makes mistakes sometimes.

> tools/winapi_check/winapi_check --none --progress
> --cross-call-unicode-ascii
>
> [...]
> dlls/winmm/driver.c: winmm & winmm: OpenDriverW: illegal call to
> HEAP_strdupWtoA (Unicode -> ASCII) dlls/winmm/driver.c: winmm & winmm:
> OpenDriverW: illegal call to OpenDriverA (Unicode -> ASCII) [...]
>
> What's the story here?

What do you mean? Why did you pick these 2 examples out of the entire list?

> I decided to take on the 'Include statements should use <> instead of ""'
> item, as it seems nobody else is working on that (except Patrick Stridvall
> who created that useful patch to winapi_cleanup of course). My plan is to
> supply one patch for each directory in $WINE_SRC/* and $WINE_SRC/dlls/*, in
> 'ls' sorting order, to keep the patch size down. Is that OK with you?

I don't think you need to do that. It's really up to Alexandre to run the
script, we've discussed this before and he does not want a patch.

BTW, if you feel like working on something, programs/winecfg is a good start.
All you need is C and Win32 programming an you're all set. Besides, it blocks
a big chuck of the 0.9 TODO:
	http://www.dssd.ca/wine/Wine-0.9-TODO.html#winecfg

-- 
Dimi.