remove some __WINESRC__es

Alexandre Julliard julliard at winehq.org
Mon Aug 25 16:30:05 CDT 2003


"Dimitrie O. Paun" <dpaun at rogers.com> writes:

> No need to clutter the header files with these tests.
> We have enough of a review process in place to avoid
> such things, and in any way, things like
>
> #ifdef __WINESRC__
> # undef UNICODE
> #endif  /* __WINESRC__ */
>
> simply encourage bad coding, hides problems, and it's
> confusing.

I agree for UNICODE, but not for NEAR, FAR etc. Allowing them in Wine
will actually encourage bad coding, since we will see FAR pointers pop
up all over the place. A better approach would be to #define them to
something like do_not_use_this when building Wine.

-- 
Alexandre Julliard
julliard at winehq.com



More information about the wine-devel mailing list