For Brian Vincent
Francois Gouget
fgouget at free.fr
Wed Aug 27 06:06:35 CDT 2003
On Wed, 27 Aug 2003, puoti at inwind.it wrote:
> Hi, I've noticed a probmel on winehq, in the wwn at the top of the page you
> have a link with your name, it links to mailto:, I suggest you add your
> email address or remove that link.
The reason is that the 'email' field of the <author> tag is not set.
Instead I see that in recent WWN issues (since issue 161) there is a
contact field with a web site URL. I guess the goal is to foil spammers
so I should not send a patch to add the email field<g>.
So the problem is that include/wwn.php does not support the 'contact'
field:
$wwn_vars = array(
[...]
'author' => $html->ahref($this->author, 'mailto:'.$this->email),
Jeremy, is it hard to modify wwn.php so that it uses the email field if
present (for old issues), and uses the contact field otherwise.
Would this work? (note that I don't know anything about PHP):
'author' => $html->ahref($this->author,
(isset($this->email) ?
'mailto:'.$this->email :
$this->contact)
),
Maybe we should even check if contact is set too:
'author' => (isset($this->email) || isset($this->contact) ?
$html->ahref($this->author,
(isset($this->email) ?
'mailto:'.$this->email :
$this->contact)
) :
$this->author),
--
Francois Gouget fgouget at free.fr http://fgouget.free.fr/
I haven't lost my mind, it's backed up on tape around here somewhere...
More information about the wine-devel
mailing list