winetest: the Wine test shell

[Ferenc Wagner]

"Dimitrie O. Paun" <dpaun at rogers.com> writes:

>   -- removed the CROSS compilation support. It should work
>      with a different build tree, but I haven't tested that

Works just fine, thanks!  Interestingly, yesterday evening I
got all kinds of problems, like the build process trying to
run WINDRES=false in the elf tree and other silly things. :)

>   -- removed striping the tests from the build. This wasn't
>      right for multiple reasons:
> 	* it was using a hardcoded 'strip' command instead
> 	  of the configure one

What about the following in maketest(s? cf. 8.3)

STRIP="$3"
DLLEXT="$4"
[...]
filename="$BINDIR/${test}_test.exe$DLLEXT"
[...]
    $STRIP -s $filename

and in Makefile.in (cf. tests.list vs 8.3 again):

winetest.rc: maketest tests.list
        $(SRCDIR)/maketest -r $(SRCDIR)/tests.list "$(STRIP)" "$(DLLEXT)" > $@ || ( $(RM) $@ && exit 1 )

> 	* it seems strange that building winetest should
> 	  magically affect all the tests

Maybe.  But nothing depends on those, so I can't see it
cause problems.  And stripping reduces the final size of the
program by an order of magnitude!  It counts on a not-so-wide
download link.

> 	* why should we strip every time

Stripping stripped programs doesn't take much time or effort.

>      Maybe we should replace this with an explicit
> 	make strip-tests
>      or some such. Suggestins are welcome.

Another possibility is to
    $STRIP -s -o ${testname}_test.exe$DLLEXT $filename
It's sterile, but I'm not sure if it's better.

> But I think it looks decent enough that it can go in, so we
> can start sending small incremental patches to it.

Shall not we put copyright notices into the files?

> +    if (remove (logname))
> +        fatal (strmake (NULL, "Can't remove logfile: %d.", errno));

Maybe a warning would be enough here, too... :)  Not that it
makes any difference, of course.

Best wishes,
Feri.