Patch for bug 1848 - TrackPopupMenu returns wrong result, when menu is canceled

Dimitrie O. Paun dpaun at rogers.com
Thu Dec 11 12:28:27 CST 2003


On December 11, 2003 01:20 pm, Andreas Rosenberg wrote:
> +    if (!(menu = MENU_GetMenu( hmenu )))
> +       {
> +       SetLastError(ERROR_INVALID_MENU_HANDLE);  /* - added by A.Rosenberg
> 2003.12.11 */ +       return FALSE;
> +       }

No need to add the 'added by ...' comment, it uglifies the code
needlessly. That info is available in the log.

Also, please try to follow the style of the file, nowhere do we
use this bracketing style.

-- 
Dimi.




More information about the wine-devel mailing list