wine/ library/debug.c include/wine/library.h i ...

[Alexandre Julliard]

"Dimitrie O. Paun" <dpaun at rogers.com> writes:

> That includes me. But since we're not going to rename everything
> (and this makes me so happy, I would have hate it if we did), the
> confusion is still going to be there. People are still going to
> have to learn that there is this mapping. But than, for magically
> chosen, obscure functions, they will have to learn another rule!

That's not another rule, it's just the standard behavior: functions
are called the same way under Wine and under Winelib. If we use the
wine_* functions in Wine too, then the rule is that in Winelib
everything is identical, except that TRACE/ERR/WARN/FIXME have to be
prefixed with WINE_. That's certainly easier and more consistent than
having a separate rule for the debugstr functions that is different
from everything else.

> Furthermore, in this very case it's not clear at all to me we are
> aiming at anything better. I have seen no project that uses this
> long names for its debugging API. There are many reasons why not,
> I will not hash them here, but this simple observation should tell
> us something.

We can certainly come up with shorter names if that's what bothers
you; personally I don't think that e.g. wine_dbgstr_guid is much worse
than debugstr_guid, but I'm certainly open to other suggestions. The
important thing is to have only one name and stick to it everywhere;
this in turn implies that it must be unique enough to not risk
conflicting with other identifiers.

-- 
Alexandre Julliard
julliard at winehq.com