wine/ library/debug.c include/wine/library.h i ...

[Dimitrie O. Paun]

On January 3, 2003 02:37 pm, Alexandre Julliard wrote:
> You can happily copy code back and
> forth between Wine and the Winelib app, and you expect it to
> work. That's the principle of least suprise again <g>

Darn, I knew you gonna get me on this one! :) Hehe, what goes
around comes around. ;)

> I'm not opposed to a define to export the TRACE/FIXME/ERR/WARN macros,
> but that's not a general solution. We don't want to have to explain
> "sure the API is broken but if you define this magic symbol you can
> make it sane again". We should define a sane API in the first place.

Hey, it is the same API afterall. It is not broken, it just uses different
names, and you have to admit the names are a bit nicer on the eye.
And speaking of these prefixes and all, I don't see why we have to use
wine_ to prefix things. We can imagine this is a debugging API that Wine
uses as well, so it might as well use a different prefix. 
What about dbg_? :)

If you really want to export only one symbol, fine, lets export the short
ones only. The 1% of apps that have conflicts can do things (in mydebug.h):

#define TRACE DEBUG
#define WARN WARNING
#include <wine/debug.h>

They'll most like have to do something like this anyway, with the only
difference that the defines come after the include, but hey, it's a small
price to pay! And if they don't like it, they don't need to use our headers
at all, they can implement their own macros on top of the functions we export
from ntdll. Come on, they are a few lines of code, is it really worth 
complicating the Wine code for it?

-- 
Dimi.