FW: shell32: SHChangeNotify is really Unicode/ANSI indifferent, take2
Dmitry Timoshkov
dmitry at baikal.ru
Tue Jan 21 00:04:13 CST 2003
"Francois Gouget" <fgouget at free.fr> wrote:
> On Tue, 21 Jan 2003, Rolf Kalbermatter wrote:
> [...]
> > @@ -289,22 +257,11 @@
> > LeaveCriticalSection(&SHELL32_ChangenotifyCS);
> >
> > /* if we allocated it, free it */
> > - if(uFlags & SHCNF_PATHA)
> > + if (uFlags & SHCNF_PATHA || uFlags & SHCNF_PATHW)
> > {
>
> Just nitpicking (since Dimitrie is on vacation ;-): it's probably not
> necessary but I would be more confortable if the above test had more
> parentheses:
>
> > + if ((uFlags & SHCNF_PATHA) || (uFlags & SHCNF_PATHW))
or even better form the effectiveness point of view:
if (uFlags & (SHCNF_PATHA | SHCNF_PATHW))
--
Dmitry.
More information about the wine-devel
mailing list