PATCH: Inserting an item in a listview sometimes generates
arg at cyberscience.com
Thu Mar 6 10:17:38 CST 2003
At 10:17 06/03/03 -0500, Dimitrie O. Paun wrote:
>On March 6, 2003 06:04 am, Adam Gundy wrote:
>[wine-devel Cc:ed to keep people in the loop]
>> Is a listview guaranteed to be single threaded? I assume it is because it
>> is all message driven - so some flag in the LISTVIEW_INFO structure could
>> be set. I'd say that is even more opaque.
>I think this would be better. It's localized in two points (where we set it,
>and where we use it), and it's easier to follow. The rest of the code should
>be unaware of this problem, so hiding it is the right thing to do IMO.
>The reason it's easier to follow is that if I don't see it, I don't care about
>it, which is what we want, and 99% of people looking at the code will fall in
>this category. If you do happen to stumble upon it, you can search for the
>infoPtr->blah thing that we're setting to see where and how this thing is used.
>You can't easily search with the current flag solution.
fine by me. you want me to do it?
Real Programmers don't comment their code. If it was hard to write,
it should be hard to read, and even harder to modify.
These are all my own opinions.
More information about the wine-devel