(4th) Janitorial dlls/advapi32/registry.c W->A cleanup

Dan Kegel dank at kegel.com
Fri Mar 7 17:24:03 CST 2003


Alexandre Julliard wrote:
> This can't work, the sprintf is supposed to modify the buffer, not a
> copy of it.
> 
> Also note that registry functions are not supposed to set last error,
> so you probably don't want to use Dmitry's wrapper here.

Hmm.  Would it be possible for janitors to as a matter
of course submit a regression test program for the
routines they are sweeping up?  That might avoid a few of these
kind of issues.
- Dan

-- 
Dan Kegel
http://www.kegel.com
http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045




More information about the wine-devel mailing list