listview advice needed.

Dimitrie O. Paun dpaun at rogers.com
Sat Nov 15 09:56:34 CST 2003


On November 15, 2003 09:43 am, Rein Klazes wrote:

OK, this looks good, but 2 small nits:

> -           dispInfo.item.iSubItem = lpLVItem->iSubItem;
> +           dispInfo.item.iSubItem = isubitem;

I'm not sure if we have to use the original one here or not.
We should add a test for this mess as well...

> +        if( !lpSubItem) {
> +            WARN(" iSubItem invalid (%08x), ignored.\n", isubitem);
> +            isubitem = 0;
> +        }

Please use the same braketing style as the rest of the code.
Also, I'm not sure this is a WARN, if this is actual behaviour,
maybe a TRACE would be better.

-- 
Dimi.




More information about the wine-devel mailing list