Reject wildcards in directory names

Rolf Kalbermatter rolf.kalbermatter at citeng.com
Fri Nov 21 02:43:39 CST 2003


Alexandre Julliard <julliard at winehq.org> wrote:

> > As for the invalid characters, [Create|Remove]File[A|W] only check
> > for '?', '*', which I just copied for [Create|Remove]Directory[A|W]. 
> > I take it you will accept a patch that also extends the checks in
> > [Create|Remove]File*?
> 
> Yes, and of course it should use a common routine to do the checks, so
> that it's consistent everywhere. Also the Create and Remove cases
> should be handled differently IMO, a Remove should succeed if the
> specified file exists, even if it contains illegal characters.

I would actually agree with Alexandre here, but W2K at least behaves
differently.
My tests show that RemoveDirectory just as CreateDirectory rejects all
paths which contain one of the wildcards ": * ? \" < > |" with error 123
completely independent where that character occurs (not just in the path
element which is created).
And as far as I can say DeleteFile just as much behaves also this way.
So should we attempt to be smarter than Windows in this case?

Rolf Kalbermatter





More information about the wine-devel mailing list