dmitry at baikal.ru
Wed Apr 7 22:13:32 CDT 2004
"Rafael аvila de EspМndola" <rafael.espindola at ic.unicamp.br> wrote:
> The attached patch fixes the problem that wine has with the abnt2 (Brazilian)
> keyboard. The problem was recently discussed in wine-devel.
If you still can't provide more arguments as on wine-devel I don't see
a reason why the patch can be accepted. Especially taking into account
that the patch contains magic numbers without a little bit of explanation
what they are.
> While reading dlls/x11drv/keyboard.c I notice that wine does a linear search
> to convert a virtKey to a keycode. Could this be optimized/simplified by
> pre-computing a vkey2keyc[(e->state & NumLockMask)!=0] table?
Feel free to send a patch.
More information about the wine-devel