Call for console and process tests help (Was: Re: Make dlls-kernel-tests-file.c
work on Windows 95 and XP.)
jakov at vmlinux.org
Mon Apr 26 15:56:04 CDT 2004
Alexandre Julliard wrote:
>Jakob Eriksson <jakov at vmlinux.org> writes:
>>+static int test_win9x_based()
>>+ OSVERSIONINFOEX ver;
>>+ ver.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
>>+ ok( GetVersionEx ((OSVERSIONINFO *) &ver), " --- Can't get OS version.\n" );
>>+ if ((4 == ver.dwMajorVersion && 0 == ver.dwMinorVersion && 1381 == ver.dwBuildNumber)
>>+ || ver.dwMajorVersion >= 5)
>>+ return 0;
>>+ return 1;
>You should not do version checks in tests, the checks should be based
>on the features we are testing. Otherwise the results are going to
>depend on the Windows version that Wine is configured for, which is
>the wrong thing to do since the behavior of the Wine code in that case
>does not depend on the version.
Okay, I understand now.
Could somebody help me fix these tests?
The thing is, I have barely no clue how the console tests work... I will
try to learn though.
More information about the wine-devel