[QUARTZ] Some pins bug fixes

Christian Costa titan.costa at wanadoo.fr
Sat Aug 14 11:50:07 CDT 2004


Robert Shearman wrote:

> Christian Costa wrote:
>
>> Hi,
>>
>> Changelog:
>> Don't fail a connection because an input pin does not expose the 
>> IMemInputPin interface (pull pins typically).
>
>
>
> This seems wrong. The FileAsyncReaderPin (and any other output pin 
> that connects to a pull pin) should override the pConnectSpecific 
> function so that it doesn't query for IMemInputPin. I can't explain 
> why this isn't currently done. 

You're simply right. This is wrong.
Ok, I will resent a patch without this change for the moment.

>
>
> I don't really like the (%p/%p)->... notation, but if it helps you in 
> debugging then it's fine.

Well, I won't repeat what Lionel said but this has been very usefull for 
debugging the quartz code.

Christian





More information about the wine-devel mailing list