OLEPictureImpl_Load: fix for headerless pictures

Kirill Smelkov kirr at landau.phys.spbu.ru
Tue Feb 3 10:56:10 CST 2004


On Tue, 3 Feb 2004, Fabian Cenedese wrote:

>
> >> I don't think that this is correct. If header[1] is 0 then it means that there is no picture at
> >> all, and not a picture without header (me thinks). When trying to start a program that uses
> >> the SSTab from TabCtl32.ocx without having assigned icons to the tabs it fails because
> >> wine tries to create icons that aren't in the stream. So there's no point in continuing and trying
> >> to read data from the stream. I could only make it work when I jump out of this function
> >> without doing anything if header[1] is 0. That may be wrong too but this patch doesn't
> >> solve it either.
> >
> >In my case there are lots of *.bmp (with picture) with exactly same header
> >i mentioned. Thus header[1]==0 doesnt imply 'there is no picture at all'
> >
> >This pictures came in ole storage taken from a real win32 app, and loading
> >them on windows works correctly.
>
> Do you have VB6? Can you create a testprogram? If not then I can send you one.
> Just create an empty form and place the SSTab on it (the one from tab control,
> not the one in the standard palette).
I don't have VB. In fact i ether dont have VC and windows installed at all
here.

If you have an winelib based example, let's try get it working.


> This fails on on my computer and I don't
> know how wine could detect if it's a headerless picture or no picture at all
> if they look the same (so far).

Maybe check header[0] to be real .bmp or .gif magic and header[1] for
zero?

--
	Kirill.





More information about the wine-devel mailing list