OLEPictureImpl_Load CreateIcon failed
Fabian Cenedese
Cenedese at indel.ch
Thu Jan 29 10:24:30 CST 2004
>>I'm still on the VB SSTab problem as described here:
>>
>>http://www.winehq.org/hypermail/wine-devel/2003/12/0157.html
>
>I now know that it works if there are icons (property Picture) assigned
>to the single tabs in the TabCtrl. But if the icons are missing, wine
>goes woo. So either wine shouldn't try to create pictures if there
>aren't any, or it should cope with failing CreateIcon calls. I guess
>the first case would be better.
May not be the right solution but makes an SSTab without icons
come up.
bye Fabi
Index: dlls/oleaut32/olepicture.c
===================================================================
RCS file: /home/wine/wine/dlls/oleaut32/olepicture.c,v
retrieving revision 1.30
diff -u -r1.30 olepicture.c
--- dlls/oleaut32/olepicture.c 5 Sep 2003 23:08:33 -0000 1.30
+++ dlls/oleaut32/olepicture.c 29 Jan 2004 16:19:25 -0000
@@ -873,6 +873,9 @@
hr=IStream_Read(pStm,header,8,&xread);
if (hr || xread!=8) {
FIXME("Failure while reading picture header (hr is %lx, nread is %ld).\n",hr,xread);
+ return hr;
+ }
+ if (header[1]==0) {
return hr;
}
if (header[1] > statstg.cbSize.QuadPart) {/* Incorrect header, assume none. */
More information about the wine-devel
mailing list