Implement StdMarshal::ReleaseMarshalData

Mike Hearn mike at navi.cx
Fri Jul 23 06:31:52 CDT 2004


On Fri, 23 Jul 2004 08:29:01 +0200, Jeroen Janssen wrote:
>> +  res = IRpcStubBuffer_Release(stub);
> 
> I'm not sure but, is there a hypothical race condition here when a
> thread switch takes place and someone tries to reuse the stub while
> valid is not set to TRUE yet (but the stub has already been released)?
> 
>> +  stubs[i].valid = FALSE;

You're right, good catch. I'm not sure it's worth resending the patch
though as really hardly any of our COM implementation is thread safe at
all. If Alexandre wants to reverse the two statements as he applies the
patch though he should feel welcome to :)




More information about the wine-devel mailing list