RPCRT4_NdrClientCall2 stub (fixme)?

Jeroen Janssen japj at xs4all.nl
Fri Jul 30 01:24:53 CDT 2004


Filip Navara wrote:
> Alexandre Julliard wrote:
> 
>> Mike Hearn <mike at navi.cx> writes:
>>
>>>> Yes, I have an implementation of NdrClientCall2 in my local tree, but
>>>> I'm a bit busy with other COM things at the moment. I'll send an 
>>>> updated
>>>> patch to the list either tonight or sometime over the weekend.
>>>>     
>>>
>>>
>>> Alexandre, why was this not merged when it was originally sent?
>>>   
>>
>>
>> No idea, please resubmit.
>>
> IIRC Robert said that the patch isn't cleaned up yet and so it shouldn't 
> be commited. He also said that he hasn't tested it much except for 
> simple tests and the complex types weren't tested at all.

Since I'm trying to run an application that is in the need of 
NdrClientCall2, I can probably do some tests with it (but I don't know 
what types are being used in it).

I'm wondering when is a patch 'good enough' to be included? (both from 
an 'enduser', an author's point of view and from Alexandre's view (who 
eventually commits the patch)?

Is there an official way to track that a patch submitted to wine-patches 
has been comitted? Also can I somehow find out which (interesting) 
patches have not been comitted yet?

Also, I noticed there is currently only one person with CVS write 
permissions for Wine? Has this always been the case?
---
Jeroen




More information about the wine-devel mailing list