[RFC] [MSVCRT] Removing the MSVCRT() hack

Alexandre Julliard julliard at winehq.org
Fri Jun 18 13:14:26 CDT 2004


"Dimitrie O. Paun" <dpaun at rogers.com> writes:

>   -- stuff that's private, doesn't start with MSVCRT_
>      From this two rules follows that a symbol starts
>      with MSVCRT_ if and only if it's shared with the
>      public headers, where it appears without MSVCRT_
>   -- most private functions start with msvcrt_ now,
>      a convetion that was already in place, but not
>      followed to the letter

There seems to be some inconsistencies in the way you did it, some
exported functions got renamed to msvcrt_, I think that's wrong.
msvcrt_ should be only for internal things, exported functions should
all use MSVCRT_.

>   -- there is a sh script that uses this simple rule
>      to generate the test file. Do we integrate the
>      script with the build system?

I think we can simply put the generated code in CVS.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list