Tainted code in User32?

[Dmitry Timoshkov]

"Steven Edwards" <steven_ed4153 at yahoo.com> wrote:

> "However, disassembling NT implementation (WIN32K.SYS) reveals
> that........."
> in
> http://source.winehq.org/source/windows/win.c#L845
> 
> was introduced in to winehq by the following patch:
> http://cvs.winehq.com/cvsweb/wine/windows/win.c.diff?r1=1.61&r2=1.62
> 
> Does this not violate a clean rooming the implementation? The ReactOS
> code is a derived work of the Wine code in the case and if soon then we
> have to remove it.

You didn't provide full comment and some minds on ros-kernel list already
started to distort the meaning of the comment. That patch was a part of
the effort running calc.exe from Windows98 under Wine, not just pulling
an arbitrary code from MS implementation. And since it was back in old
Wine days (commit date: Sat Jun  5 15:23:20 1999) Wine didn't have any
testing framework at that time.

Here is full changelog for the change:

 * windows/win.c: Slava Monich <Slava.Monich at netmanage.com>
 o check for both CW_USEDEFAULT and CW_USEDEFAULT16.
 o if x is CW_USEDEFAULT (or CW_USEDEFAULT16) and y is *not*
   CW_USEDEFAULT (or CW_USEDEFAULT16) then use y as a second
   parameter to ShowWindow(). Some apps (CALC.EXE for Win98
   is one of them) use this undocumented feature to create
   hidden window with WS_VISIBLE style set.

-- 
Dmitry.