Edit - wants all keys when multiline

Dmitry Timoshkov dmitry at baikal.ru
Sun Oct 31 21:23:49 CST 2004


"Vitaliy Margolen" <wine-patch at kievinfo.com> wrote:

> @@ -761,6 +761,12 @@
>  
>   case WM_GETDLGCODE:
>    result = DLGC_HASSETSEL | DLGC_WANTCHARS | DLGC_WANTARROWS;
> +  
> +  if (GetWindowLongW( hwnd, GWL_STYLE ) & ES_MULTILINE)
> +  {
> +     result |= DLGC_WANTALLKEYS;

EDITSTATE structure already has the 'style' member for the optimization
sake, so please use it instead of GetWindowLong(GWL_STYLE).

> + r = SendMessage(hwEdit, WM_GETDLGCODE, 0, (LPARAM) &msMessage);
> + ok(r==0x89, "Expected DLGC_WANTCHARS | DLGC_HASSETSEL | DLGC_WANTARROWS got %x\n", r);

Do not use 0x89 and similar cryptic values in the test, use appropriate
symbolic constants instead.

And please merge your test into existing win.c tests.

-- 
Dmitry.




More information about the wine-devel mailing list