Revised menu patch

[Michael Kaufmann]

Hi Dmitry

>>My last menu patch didn't pass a test case. I've commented out this test 
>>case, because it tests undocumented behavior.
>>    
>>
>
>That's a very bad idea, then you need to comment out half of the test
>cases in Wine. The tests show *the real* behaviour, it doesn't really
>matter whether it's documented or not, it's known that MSDN has lots
>of misleading and missing information.
>  
>

How do you define the "real behavior" ? The behavior of Windows XP? Have 
you checked that Windows 2003 still passes this test? You can't be sure. 
There's no real behavior in this case.


>>We should re-activate this 
>>testcase as soon as WINE passes it. This will be the case when the menu 
>>code is moved to WineServer, as Dmitry pointed out.
>>    
>>
>
>Then it has a good chance that the bug will be never fixed at all.
>A commented out test does not differ from a not existent one, and
>has zero chance to be revived.
>  
>

I promise that I'll remember you to reactivate this testcase. If we 
don't modify DestroyMenu NOW, there's also a good chance that this bug 
will never be fixed. Remember, a lot of Delphi applications don't work 
because of this bug which is simple to fix and breaks only one single 
testcase. Is is really more important that WINE passes this test but 
fails on Delphi apps again and again? What will the users of WINE think?

To fix it properly, we have to move the menu code to WineServer. When 
will this happen? In a year? In two years? Never? Until then, many 
Delphi apps won't work. For me, this is not acceptable.


Regards

Michael