dib.c problem, and Solution to winmm deadlocking problem

Matthew Mastracci matt at aclaro.com
Sat Apr 9 22:22:01 CDT 2005


Robert Lunnon wrote:

> After weeks of searching I have finally found my deadlock problem. 
> Its actually not related to audio at all it's a ddraw problem with poor error handling, the surface wasn't released properly when  the error
>  "Application gave us bad source rectangle for Blt." occurs

I addressed part of this bug in my latest DDRAW patch from last week 
(DDRAW: Surface locking patch, take 3 [repost]), but I missed the 
"return ret;" part of it.  doh!

> @@ -959,7 +961,7 @@ error:
>  release:
>      IDirectDrawSurface7_Unlock(iface,NULL);
>      if (src) IDirectDrawSurface7_Unlock(src,NULL);
> -    return DD_OK;
> +    return ret;
>  }

I'll have to update my patch once more with this fix.

Matt.




More information about the wine-devel mailing list