LoadImage (4bpp) / CopyImage() crashing

Cyril Margorin comargo at gmail.com
Fri Dec 9 16:45:21 CST 2005


Unfortunately, problem is that GetBitmapBits function in wine is
incorrect, and may causes a buffer overflow, but the GetDIBits isn't.

2005/12/10, Mike McCormack <mike at codeweavers.com>:
> Cyril Margorin wrote:
>
> > Could anyone tell me, why function CopyImage uses
> > GetBitmapBits/SetBitmapBits, while MSDN marks these function as
> > absolete?
>
> No matter what MSDN says, Wine still has to provide implementations of
> those functions, as programs still use them.  Since we *must* have
> implementations of them, then there's no reason why we shouldn't use
> those implementations in our code too.
>
> Perhaps MSDN should say "we wrote new fancy versions of these functions
> and we want everybody to use them".  Don't pay too much attention to it.


--
Cyril Margorin



More information about the wine-devel mailing list