_itow tests in ntdll/tests
paul.vriens at xs4all.nl
Fri Dec 23 03:54:17 CST 2005
> I am the author of the _itow tests and the _itow function.
> As far as I can remember when I tested the _itow functions under WIN2000
> and under XP (No SP or just SP1) it was allowed to call _itow with
> _itow(123, NULL, 10)
> and the result of this call was NULL.
> The wine _itow function implemented this functionality because of
> "bug by bug" compatibility (Some Applications might be based on this
> "Feature"). The Test was done to find regressions or changes in the M$
> operating systems. In my opinion testing corner cases is important.
> What does "there is failure" mean. Does it crash or return something
> different from NULL. When it crashes under XP SP2 the function _itow
> should remain unchanged. When some other value (different from NULL) is
> returned it might be necessary to change _itow.
the tests show failed on tests.winehq.org. When running the tests by
themselves a nice Microsoft Error box is shown (dwwin.exe).
How come the tests have to remain unchanged when crashing? After the first
crash the rest of the tests are not run anymore, hence no tests ! I don't
think we want that either.
More information about the wine-devel