Preliminary CD-Rom support on MacOS X #2

emmanuel maillard e.rsz at libertysurf.fr
Fri Dec 30 12:10:44 CST 2005


Hi,

Thanks for the comment, i agree with it but i was thinking than  
keeping separated patches was better than (in this case)
merging  #2 + #3 + #5 in a big patch.

Any tricks are welcome.

Thanks

Emmanuel

Le 30 déc. 05 à 13:08, Robert Shearman a écrit :

> emmanuel maillard wrote:
>
>> Changelog :
>>     kernel/proces.c : Initialize darwin removable devices
>
>
> I appreciate you splitting up your patches for easier review, but  
> patches are meant to be independent atomic changes that improve the  
> code. However, if Alexandre applied this patch alone then Wine  
> wouldn't compile any more and this isn't acceptable.
>
> -- 
> Rob Shearman
>
>
>




More information about the wine-devel mailing list