[shlwapi/tests/shreg] Tests question

Paul Vriens Paul.Vriens at xs4all.nl
Sat Jan 29 12:03:04 CST 2005


On Sat, 2005-01-29 at 18:29, Juan Lang wrote:
> > What's the best approach in this?
> > - fix Wine (but what should be the correct returned buffer?)
> 
> Definitely fix Wine.  Hopefully there isn't an app that depends on one
> behavior under Windows 98, and a different one under Windows XP.  It's
> perhaps less likely because Wine's implementation isn't correct in either
> case?  Pick one of the versions to match, document the difference with
> other versions.
> 
> If needed later someone can change the function to check at runtime which
> version of Windows is being emulated, and match the behavior accordingly. 
> See e.g.
> http://source.winehq.org/source/dlls/kernel/process.c#L2800
> for where this is done.
> 
> --Juan
> 
I will give it a try. Is it OK to submit patches to the tests first
(with todo_wine maybe) before I get into the fixing of Wine?

The major reasoning behind this is to get more test output from
different systems. I've tested it on 6 or so but there's a lot more out
there.

Paul.




More information about the wine-devel mailing list