USER32: Error checking for sysparams tests
Paul Vriens
Paul.Vriens at xs4all.nl
Sat Mar 5 07:58:00 CST 2005
On Sat, 2005-03-05 at 06:42, jchevrier at nexicom.net wrote:
> As discussed on wine-devel there are a handful of calls in the
> SystemParametersInfo tests that don't check for returned errors and continue
> on with testing a given parameter. This patch ensures that all initial calls
> to SystemParametersInfoA in each parameter test have their returned errors
> checked. To ease adding more error cases and reduce code duplication I have
> consolidated error message handling into a single function.
>
> Changelog:
>
> * Consolidate error message handling
> * Add error checking to all initial SystemParametersInfoA calls in each
> parameter test to make sure that if a given parameter isn't supported or has
> failed in some other way that we return and don't continue on with the test
> * Remove a couple of TABS and align registry keys/values at the top of the
> file
Hi Justin,
what about the attached one? Added/changed the following:
- Always set LastError before calling test_error_msg
- SPI_{GET,SET}ICONTITLEWRAP is supported on Win98, but was clouded by
an error that was set after a previous call failed.
Changelog:
Justin Chevrier <jchevrier at nexicom.net>
* Consolidate error message handling
* Add error checking to all initial SystemParametersInfoA calls in each
parameter test to make sure that if a given parameter isn't supported or
has failed in some other way that we return and don't continue on with
the test
* SetLastError before calling test_error_msg
* Remove a couple of TABS and align registry keys/values at the top of
the file
* SPI_{GET,SET}ICONTITLEWRAP is supported on Win98
Cheers,
Paul.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sysparams_tests_errors_2.diff
Type: text/x-patch
Size: 24549 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20050305/ed024411/sysparams_tests_errors_2.bin
More information about the wine-devel
mailing list