Clipboard regression

[Ron Jensen]

>Hello List,
>
>This patch from 2005/03/07 causes a Clipboard regression:
>
>http://www.winehq.org/hypermail/wine-cvs/2005/03/0111.html
>
>Whenever the clipboard is used the process crashes with an X error.
>To reproduce it just start notepad and right click into the text area:

This also seems to be the cause of X11 errors I am seeing with IrfanView
and Textpad.  Both apps fail at startup with an X Error, IrfanView is the 
simpler case:

:~$ WINEDEBUG=clipboard wine C/Program\ Files/IrfanView/i_view32.exe
trace:clipboard:X11DRV_CLIPBOARD_InsertClipboardFormat Registering format(49173): L"Rich Text Format" drvData 399
trace:clipboard:X11DRV_CLIPBOARD_InsertClipboardFormat Registering format(49174): L"GIF" drvData 396
trace:clipboard:X11DRV_IsClipboardFormatAvailable (0008)
trace:clipboard:X11DRV_EmptyClipboard  0 entries remaining in cache.
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  1 (X_CreateWindow)
  Serial number of failed request:  208
  Current serial number in output stream:  209

The offending function seems to be the calls to X11DRV_CLIPBOARD_QueryTargets() in
X11DRV_CLIPBOARD_QueryAvailableData().

X11DRV_IsClipboardFormatAvailable() calls X11DRV_CLIPBOARD_UpdateCache() which calls
X11DRV_CLIPBOARD_QueryAvailableData() which calls  X11DRV_CLIPBOARD_QueryTargets() which
throws the X Error.

These apps both work if started in a desktop window.

Ron Jensen