SHELL32: minor fix in debughlp.c (crash in file dialogs)

Mike McCormack mike at codeweavers.com
Thu Mar 17 07:36:57 CST 2005


This following patch breaks the file open dialog, so if your file open 
dialog box crashes in the CVS, this is the thing to revert.

_dbg_ILGetNext doesn't seem to return NULL if pidl->mkid.cb is zero...

Mike


Filip Navara wrote:
> _dbg_ILGetNext returns NULL if pidl->mkid.cb is zero, fix the
> loops accordingly.
> 
> 
> ------------------------------------------------------------------------
> 
> --- dlls/shell32/debughlp.c
> +++ dlls/shell32/debughlp.c
> @@ -215,7 +215,7 @@
>  
>  	      pidltemp = _dbg_ILGetNext(pidltemp);
>  
> -	    } while (pidltemp->mkid.cb);
> +	    } while (pidltemp);
>  	  }
>  	  else
>  	  {
> @@ -275,7 +275,7 @@
>  	      }
>  	    }
>  	    pidltemp = _dbg_ILGetNext(pidltemp);
> -	  } while (pidltemp->mkid.cb);
> +	  } while (pidltemp);
>  	}
>  	return ret;
>  }



More information about the wine-devel mailing list