visual regression in IE

[Joris Huizer]

Robert Shearman wrote:
> Joris Huizer wrote:
> 
>> James Hawkins wrote:
>>
>>> On Thu, 24 Mar 2005 23:39:22 +0100, Joris Huizer 
>>> <jorishuizer at planet.nl> wrote:
>>>
>>>> Could someone point me to the correct pages to find out what caused
>>>> this? I'm sure someone will be fix this a lot faster than I could do 
>>>> but
>>>> I want to learn how to solve such a problem :)
>>>>
>>>
>>>
>>> You could run a regression test.
>>> http://www.winehq.org/site/docs/wine-devel/x1318
>>>
>>
>> Okay, I found the regression happened some time on 23 march:
>>   cvs update -PAd -D "2005-03-23 CDT" doesn't have the regression
>>   cvs update -PAd -D "2005-03-24 CDT" has the regression
>>
>> Now how will I be able to find exactly what's causing it? Can I 
>> download the individual patch files of that date somehow?
> 
> 
> 
> Thanks for narrowing the regression down.
> 
> Does the attached patch help?
> 
> Rob
> 

Yeah, after applying the patch IE draws its bar normally again :)
(Also I think I got closer to being able to do regression testing now)

Thanks,

regards,

Joris


> ------------------------------------------------------------------------
> 
> Index: dlls/comctl32/rebar.c
> ===================================================================
> RCS file: /home/wine/wine/dlls/comctl32/rebar.c,v
> retrieving revision 1.107
> diff -u -p -r1.107 rebar.c
> --- dlls/comctl32/rebar.c	23 Mar 2005 13:15:21 -0000	1.107
> +++ dlls/comctl32/rebar.c	26 Mar 2005 20:27:04 -0000
> @@ -4122,7 +4122,7 @@ REBAR_NCCreate (HWND hwnd, WPARAM wParam
>      SetWindowLongW (hwnd, GWL_STYLE, infoPtr->dwStyle);
>  
>      /* get font handle for Caption Font */
> -    ncm.cbSize = sizeof(NONCLIENTMETRICSA);
> +    ncm.cbSize = sizeof(ncm);
>      SystemParametersInfoW (SPI_GETNONCLIENTMETRICS, ncm.cbSize, &ncm, 0);
>      /* if the font is bold, set to normal */
>      if (ncm.lfCaptionFont.lfWeight > FW_NORMAL) {