Resent^2 : Zero out return string in GetMenuStr
Uwe Bonnes
bon at elektron.ikp.physik.tu-darmstadt.de
Tue Mar 29 12:48:15 CST 2005
>>>>> "Alexandre" == Alexandre Julliard <julliard at winehq.org> writes:
Alexandre> Uwe Bonnes <bon at elektron.ikp.physik.tu-darmstadt.de> writes:
>> Anything wrong with this patch?
>>
>> Changelog: dlls/user/menu.c: GetMenuStrA|W Initialize return string
>> as an empty string
Alexandre> You need to take the specified length into account before
Alexandre> writing to the string.
Alexandre,
also before, there was a NULL written to position Zero of the
string. However there where some checks and function calls that could
return Zero but didn't touch the string. Now there is only a check
that the argument is a pointer before the Null is written. What should be
done in another way?
--
Uwe Bonnes bon at elektron.ikp.physik.tu-darmstadt.de
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
More information about the wine-devel
mailing list