Regression in Half life

[Stefan Dösinger]

Hello,
These two patches cause a regression in Half-Life (Version 1.1.1.0):

(1)http://www.winehq.org/hypermail/wine-cvs/2005/04/0307.html
(2)http://www.winehq.org/hypermail/wine-cvs/2005/04/0308.html

Half-life reports "ChoosePixelFormat failed", followed by "The Selected OpenGL 
mode is not supported by your card" when starting the engine. Wine prints the 
following error:

err:opengl:X11DRV_ChoosePixelFormat glXChooseFBConfig returns NULL (glError: 
0)

Reversing the above 2 patches fixes the problem. Reversing patch 1 only causes 
a crash, if I reverse only patch 2 the problem still exists.

Cheers,
Stefan

Here's a +opengl trace
trace:opengl:X11DRV_OpenGL_Init GLX is up and running error_base = 77
fixme:ddraw:Main_DirectDraw_SetCooperativeLevel 
(0x77c71a58)->(00000000,00000008)
fixme:ddraw:Main_DirectDraw_SetCooperativeLevel 
(0x77c71a58)->(00000000,00000013)
fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum
fixme:mmtime:timeEndPeriod Stub; we set our timer resolution at minimum
fixme:ddraw:Main_DirectDraw_SetCooperativeLevel 
(0x77c71a58)->(00000000,00000008)
fixme:ddraw:Main_DirectDraw_SetCooperativeLevel 
(0x77c71a58)->(00010028,00000013)
fixme:win:LockWindowUpdate (0x10028), partial stub!
fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum
fixme:win:LockWindowUpdate ((nil)), partial stub!
fixme:ddraw:Main_DirectDraw_SetCooperativeLevel 
(0x77c71a58)->(00000000,00000008)
fixme:ddraw:Main_DirectDraw_SetCooperativeLevel 
(0x77c71a58)->(00010028,00000013)
fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 
16
fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 
16
fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 
16
fixme:win:LockWindowUpdate (0x10028), partial stub!
fixme:win:LockWindowUpdate ((nil)), partial stub!
fixme:win:LockWindowUpdate (0x10028), partial stub!
fixme:win:LockWindowUpdate ((nil)), partial stub!
fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 
16
trace:opengl:wgl_ext_initialize_extensions GL version      : "1.3.5010 
(X4.3.0-8.12.10)".
trace:opengl:wgl_ext_initialize_extensions GL exts         : 
"GL_ARB_multitexture GL_EXT_texture_env_add GL_EXT_compiled_vertex_array 
GL_S3_s3tc GL_ARB_occlusion_query GL_ARB_point_parameters 
GL_ARB_texture_border_clamp GL_ARB_texture_compression 
GL_ARB_texture_cube_map GL_ARB_texture_env_add GL_ARB_texture_env_combine 
GL_ARB_texture_env_crossbar GL_ARB_texture"....
trace:opengl:wgl_ext_initialize_extensions GLX exts        : 
"GLX_EXT_visual_info GLX_EXT_visual_rating GLX_EXT_import_context 
GLX_ARB_get_proc_address GLX_ARB_multisample ".
trace:opengl:wgl_ext_initialize_extensions Server GLX exts : 
"GLX_ARB_multisample GLX_EXT_visual_info GLX_EXT_visual_rating 
GLX_EXT_import_context GLX_OML_swap_method GLX_SGI_make_current_read 
GLX_SGIS_multisample GLX_SGIX_fbconfig GLX_ARB_get_proc_address ".
trace:opengl:wgl_ext_initialize_extensions Client GLX exts : 
"GLX_EXT_visual_info GLX_EXT_visual_rating GLX_EXT_import_context 
GLX_ARB_get_proc_address GLX_ARB_multisample GLX_ATI_pixel_format_float 
GLX_ATI_render_texture ".
fixme:opengl:query_function_pbuffer gl_version is: "1.3.5010 (X4.3.0-8.12.10)"
fixme:opengl:query_function_pbuffer glx_exts is: "GLX_EXT_visual_info 
GLX_EXT_visual_rating GLX_EXT_import_context GLX_ARB_get_proc_address 
GLX_ARB_multisample"
fixme:opengl:query_function_pbuffer gl_version is: "1.3.5010 (X4.3.0-8.12.10)"
fixme:opengl:query_function_pbuffer glx_exts is: "GLX_EXT_visual_info 
GLX_EXT_visual_rating GLX_EXT_import_context GLX_ARB_get_proc_address 
GLX_ARB_multisample"
trace:opengl:wgl_ext_initialize_extensions Supporting following WGL 
extensions : "WGL_ARB_extensions_string WGL_EXT_extensions_string 
WGL_ARB_make_current_readWGL_ARB_multisample WGL_ARB_pbuffer 
WGL_ARB_pixel_format WGL_EXT_swap_control".
trace:opengl:X11DRV_ChoosePixelFormat (0x77cc5448,0x1df4964)
  - size / version : 40 / 1
  - dwFlags : PFD_DOUBLEBUFFER PFD_DRAW_TO_WINDOW PFD_SUPPORT_OPENGL
  - iPixelType : PFD_TYPE_RGBA
  - Color   : 24
  - Red     : 0
  - Green   : 0
  - Blue    : 0
  - Alpha   : 0
  - Accum   : 0
  - Depth   : 32
  - Stencil : 0
  - Aux     : 0
  - iLayerType : PFD_MAIN_PLANE
err:opengl:X11DRV_ChoosePixelFormat glXChooseFBConfig returns NULL (glError: 
0)
trace:opengl:wglMakeCurrent ((nil),(nil))
trace:opengl:wglMakeCurrent  returning True
fixme:win:LockWindowUpdate (0x10028), partial stub!
fixme:win:LockWindowUpdate ((nil)), partial stub!
fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 
16
fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 
16
fixme:mmtime:timeEndPeriod Stub; we set our timer resolution at minimum