wininet: Implement InternetCreateUrlA/W with test cases
marcus at jet.franken.de
Tue Nov 1 05:47:15 CST 2005
On Tue, Nov 01, 2005 at 12:35:00PM +0100, Andreas Mohr wrote:
> On Fri, Oct 28, 2005 at 09:48:08AM -0700, Juan Lang wrote:
> > Hi James,
> > +/* max port num is 655936 => 6 digits */
> > Actually, it's 65535. A correct comment would be appreciated ;)
> > + *lpdwUrlLength += strlen("://");
> > You should use sizeof instead to avoid the call to strlen. Same for other
> > lengths you use, like "@" and ":".
> OK, done! ;)
> Replace all Wine instances of doing a strlen() on a string literal
> by its equivalent but much less onerous sizeof() - 1.
Please just keep it as is.
The compiler knows strings constants and strlen() and will replace
it by a constant on compile time.
More information about the wine-devel