[wininet]add implementation of few more options - try5

Juan Lang juan_lang at yahoo.com
Wed Nov 9 10:10:51 CST 2005


Hi Vijay,

+  hurl =
InternetConnectA(hinet,"www.winehq.com",INTERNET_DEFAULT_HTTP_PORT,NULL,NULL,INTERNET_SERVICE_HTTP,0,0);
+  ok((hurl != 0x0),"InternetConnect Failed\n");
+  
+  if( hurl == 0x0)
+  {
+     InternetCloseHandle(hurl);
+     InternetCloseHandle(hinet);
+     return;
+  }

The ok after InternetConnectA shouldn't be there.  You don't want the test
to fail if it couldn't connect; as I said before, there are many reasons
the connection could fail.

Also, in the if block below, there's no reason to call InternetCloseHandle
when hurl is 0.

Thanks,
--Juan


		
__________________________________ 
Start your day with Yahoo! - Make it your home page! 
http://www.yahoo.com/r/hs



More information about the wine-devel mailing list