mm driver message handling in DefDriverProc

Saulius Krasuckas saulius2 at ar.fi.lt
Sat Nov 12 05:49:21 CST 2005


* 6 years, 7 months ago Eric Pouech did a change [*]:
> 
> Started calling mixer as a 32 bit low level driver (no longer 16 bit)
> Added support for yield proc in mci struct
> Added mmTaskXXX16 and mmThreadXXX16 functions
> Refreshed implementation of 16 bit native & asynchronous MCI driver command (through mmtask.tsk).
  ...
> @@ -4193,13 +4273,13 @@ LRESULT WINAPI DefDriverProc(DWORD dwDri
>  {
>      switch (Msg) {
>      case DRV_LOAD:
> +    case DRV_FREE:
> +    case DRV_ENABLE:
>      case DRV_DISABLE:
> +        return 1;
>      case DRV_INSTALL:
> -        return 0;
> -    case DRV_ENABLE:
> -    case DRV_FREE:
>      case DRV_REMOVE:
> -        return 1;
> +        return DRV_SUCCESS;
>      default:
>          return 0;
>      }

I'm do not follow a logic, as nowadays PSDK defines DRV_SUCCESS as 0x0001.  
Eric, can't both cases of 1 and DRV_SUCCESS be merged into a single case?  
Maybe this change address some 16-bit issues.  No?


[*] http://cvs.winehq.org/cvsweb/wine/multimedia/Attic/mmsystem.c.diff?r1=1.24&r2=1.25&hideattic=0




More information about the wine-devel mailing list