Visual changes after running tests

[Paul Vriens]

>> On Sun, 20 Nov 2005 17:02:21 +0100, you wrote:
>>
>>>Hi,
>>>
>>>with the latest winetest suite I've noticed the following changes:
>>>
>>>- On win98 my taskbar get's twice the size it used to be.
>>>- On win98/winxp the window border is a lot thicker.
>>>- On winxp the icons in my taskbar are a lot bigger. And also the icons
>>>in for example regedit.
>>>
>>>the first and last one prevail (even after rebooting). The second one
>>>seems to intermittently stay.
>>>
>>>I'll have a look myself later on but just wanted some confirmation.
>>
>> The first one is definitely caused by my re-enabling of the
>> SPI_GET/SETBORDER tests in user/tests/sysparams.c. The problem here is
>> that the default border is 1, which is also the minimum accepted. If you
>> don't allow bigger borders (causing the task bar to expand) then there
>> cant be tests. No need for rebooting, you can easily correct it with the
>> mouse.
>>
>> The second I don't see, but since it is about borders this could be the
>> same patch. Can you tell if the sysparams test is causing it?
>>
>> Rein.
>>
> Hi Rein,
>
> the problem with the big icons is due to the fact that (somehow)
> CaptionWidth is changed.
>
> One thing that doesn't look correct in tests/sysparams.c :
>
> 586     /* The SPI_SETBORDER seems to be buggy on Win9x/ME (looks like you
> need to
> 587      * do it twice to make the intended change). So skip parts of the
> tests on
> 588      * those platforms */
> 589     iswin9x = GetVersion() & 0x80000000;
>
> and later on :
>
> 613     if( !iswin9x) {
> 614         test_setborder(1,  1, dpi);
> 615         test_setborder(0,  1, dpi);
> 616         test_setborder(7,  1, dpi);
> 617         test_setborder(20, 1, dpi);
> 618     }
>
> so were doing the test twice if it's not win9x/ME ??
>
> Cheers,
>
> Paul.
>
Forget the remark about the code. Should learn to read.

Paul.