STATUS_* definitions

Ge van Geldorp gvg at reactos.org
Sun Nov 27 07:40:35 CST 2005


> From: Vitaliy Margolen
> 
> Saturday, November 26, 2005, 10:34:22 AM, Ge van Geldorp wrote:
> > As proposed here:
> > http://www.winehq.org/pipermail/wine-devel/2005-November/042583.html
> > I didn't receive any replies, which I'll take as a "no objections".
> 
> > Changelog:
> >   Ge van Geldorp <gvg at reactos.org>
> >   - Match PSDK STATUS_* definitions
> 
> > Index: dlls/ntdll/cdrom.c
> > ===================================================================
> > RCS file: /home/wine/wine/dlls/ntdll/cdrom.c,v
> > retrieving revision 1.72
> > diff -u -r1.72 cdrom.c
> > --- dlls/ntdll/cdrom.c	26 Oct 2005 10:13:09 -0000	1.72
> > +++ dlls/ntdll/cdrom.c	26 Nov 2005 17:28:00 -0000
> I don't think we should touch ntdll in this way. As it should 
> use NTSTATUS (long int) instead of (DWORD).

I'm not sure I understand what you mean. I didn't touch the definition of
NTSTATUS in winternl.h, it is still long int. If the typecast changes in
ntstatus.h and winnt.h are made so they are compatible with the PSDK then
ntdll and server need to be modified in order to avoid compile-time
warnings.

Gé van Geldorp.




More information about the wine-devel mailing list