[kernel] correct OpenFile test

[Oliver Stieber]

--- Dmitry Timoshkov <dmitry at baikal.ru> wrote:

> "Dmitry Timoshkov" <dmitry at baikal.ru> wrote:
> 
> > >    This patch corrects the test for OpenFile with a style of OF_EXIST. The test should fail
> if the
> > > function returns anything other than HFILE_ERROR as a failure. This is based on
> > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/fs/openfile.asp and
> > > debugging 'No One Lives Forever Demo' (ftp://ftp.lith.com/pub/nolf/NOLFDemo.zip)
> > 
> > Did you run the test on a real Windows machine or just have read MSDN?
> 
> On XP SP1 the test fails (I replaced GetLastError() by the returned hFile):
> 
> file.c:1413: Test failed: hFile != FALSE : -1

-1 is HFILE_ERROR and  FALSE is 0  (defined in windef.h), is this running the old or the patched
one?

Oliver.

> 
> So it looks like the test is not entirely correct.
> 
> -- 
> Dmitry.
> 
> 
> 
> 



		
___________________________________________________________ 
How much free photo storage do you get? Store your holiday 
snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com