[kernel] correct OpenFile test
Oliver Stieber
oliver_stieber at yahoo.co.uk
Mon Oct 17 10:01:39 CDT 2005
--- Dmitry Timoshkov <dmitry at baikal.ru> wrote:
> "Oliver Stieber" <oliver_stieber at yahoo.co.uk> wrote:
>
> > > file.c:1413: Test failed: hFile != FALSE : -1
> >
> > -1 is HFILE_ERROR and FALSE is 0 (defined in windef.h), is this running the old or the
> patched
> > one?
>
> It's the result of running existing tests. I just wanted to point out
> that the second chunk of your patch looks ok, but the first part should be
> left unchanged. Also, the code in dlls/kernel/file.c,OpenFile() needs to be
> fixed as well to make your tests pass.
>
Sure, I'll fix the failure text too, I wasn't sure about the protocol for backing out bugs that
caused regression.
Oliver.
> --
> Dmitry.
>
>
___________________________________________________________
Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com
More information about the wine-devel
mailing list