[kernel] correct OpenFile test

Maxime Bellengé maxime.bellenge at wanadoo.fr
Mon Oct 17 14:30:26 CDT 2005


For me returning HFILE_ERROR makes one of my application installer
fails. If the function returns FALSE, it behaves normaly and exactly
like on windows. The application installer works correctly.

Maxime


On Mon, 2005-10-17 at 15:20 +0100, Oliver Stieber wrote:
> --- Dmitry Timoshkov <dmitry at baikal.ru> wrote:
> 
> > "Oliver Stieber" <oliver_stieber at yahoo.co.uk> wrote:
> > 
> > >    This patch corrects the test for OpenFile with a style of OF_EXIST. The test should fail if
> > the
> > > function returns anything other than HFILE_ERROR as a failure. This is based on
> > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/fs/openfile.asp and
> > > debugging 'No One Lives Forever Demo' (ftp://ftp.lith.com/pub/nolf/NOLFDemo.zip)
> > 
> > Did you run the test on a real Windows machine or just have read MSDN?
> 
> I've haven't run it on a real Windows machine as my windows install is broken at the moment.
> Returning HFILE_ERROR is the only thing that fixes 'No One Lives Forever Demo' so I'm puzzled as
> to why the test is incorrect in the first place. (Also I haven't debugged the No One Lives Forever
> Demo to verify that it is doing a cmp eax, HFILE_ERROR, but I can do).
> 
> Oliver.
> 
> > 
> > -- 
> > Dmitry.
> > 
> > 
> 
> 
> 		
> ___________________________________________________________ 
> How much free photo storage do you get? Store your holiday 
> snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com
> 
> 
> ---------------------------------------------------------------------------------------
> Wanadoo vous informe que cet  e-mail a ete controle par l'anti-virus mail. 
> Aucun virus connu a ce jour par nos services n'a ete detecte.
> 
> 
> 





More information about the wine-devel mailing list