wininet: Implement InternetCreateUrlA/W with test cases
wino at piments.com
wino at piments.com
Fri Oct 28 12:22:11 CDT 2005
On Fri, 28 Oct 2005 18:48:08 +0200, Juan Lang <juan_lang at yahoo.com> wrote:
> Hi James,
>
> +/* max port num is 655936 => 6 digits */
>
> Actually, it's 65535. A correct comment would be appreciated ;)
>
> + *lpdwUrlLength += strlen("://");
>
> You should use sizeof instead to avoid the call to strlen. Same for
> other
> lengths you use, like "@" and ":".
>
> + if (lpUrlComponents->nPort != 80 ||
>
> This seems a bit funny. Port 80 has no meaning for INTERNET_SCHEME_FTP
> or
> any other non-HTTP protocol, does it?
>
> --Juan
>
AFAIK port 80 is merely a conventional default port for HTTP, as with most
protocols. My IP blocks pop on port 25 so I move it. Idem. amule ports and
all other services.
21 is the default for ftp but there should be nothing to block it being
configged otherwise.
;)
>
>
> __________________________________
> Yahoo! Mail - PC Magazine Editors' Choice 2005
> http://mail.yahoo.com
>
>
>
More information about the wine-devel
mailing list