The Holy Grail - Wine 0.9 - thanks to all

Christian Costa titan.costa at wanadoo.fr
Sun Oct 30 06:46:13 CST 2005


H. Verbeet wrote:

>On 10/30/05, Christian Costa <titan.costa at wanadoo.fr> wrote:
>  
>
>>IIRC, a patch fixing this problem was commited about 2 or 3 months ago.
>>    
>>
>This one? http://cvs.winehq.org/patch.py?id=18002
>
>It doesn't touch CreateLight. The crash happens because of this check
>in GL_IDirect3DImpl_3_2T_1T_CreateLight:
>
>    if (fl == MAX_LIGHTS) {
>        return DDERR_INVALIDPARAMS; /* No way to say 'max lights reached' ... */
>    }
>
>The application is sloppy for not checking the result of course, but
>on Windows the call never fails, at least not for creating more lights
>than the hardware supports.
>  
>
This one, yes !
I've just taken a look at it again and it seems the patch only fixed the 
D3D7 API.
Older ones should be fixed too. I'll try to fix it today if nobody is 
working on it.






More information about the wine-devel mailing list