DDRAW: Fix reference counting

Stefan Dösinger stefandoesinger at gmx.at
Mon Sep 19 02:27:05 CDT 2005


Hi,
> Why do you increase the refcount by 2? Since you add and release them in
> the same functions, it is not really necessary and just adds complexity
> to the code.
Well, Windows does so for some reason, and after what I've seen with Empire 
Earth, I suspect that there are some apps out there which depend on things 
like this. It's unlikely, but I would not be surprised if that happens.

> if (!FAILED(hr)) -> if (SUCCEEDED(hr))
Could have guesses this one. Thanks.

Thanks, for your suggestions,
Stefan



More information about the wine-devel mailing list