hhctrl: Correctly draw the navigation pane

Dmitry Timoshkov dmitry at baikal.ru
Mon Sep 19 03:40:46 CDT 2005


"Robert Shearman" <rob at codeweavers.com> wrote:

> >@@ -149,7 +144,7 @@ static void HH_RegisterChildWndClass(HHI
> >     wcex.hInstance      = pHHInfo->hInstance;
> >     wcex.hIcon          = LoadIconW(NULL, (LPCWSTR)IDI_APPLICATION);
> >     wcex.hCursor        = LoadCursorW(NULL, (LPCWSTR)IDC_ARROW);
> >-    wcex.hbrBackground  = (HBRUSH)(COLOR_3DFACE);
> >+    wcex.hbrBackground  = (HBRUSH)(COLOR_MENU);
> >  
> >
> 
> This doesn't seem right. You're not registering a menu-like class.

Moreover, when using COLOR_xxx constants in the place of a brush one
needs to increase the value by 1 in order to make it work.

dlls/msi/dialog.c, dlls/shlwapi/ordinal.c, programs/notepad/main.c
have the same problem.

-- 
Dmitry.




More information about the wine-devel mailing list