winhelp: fix LZ77 decompressor patch: what's wrong?
HolyLich
lich at math.spbu.ru
Fri Aug 11 08:44:44 CDT 2006
В сообщении от Friday 11 August 2006 17:17 вы написали:
> 2006/8/11, HolyLich <lich at math.spbu.ru>:
> > I've sent patch several times, but it has not been applied.
>
> Why not use memmove() instead?
>
Heh, this problem was discussed before http://www.winehq.org/pipermail/wine-devel/2006-August/050133.html,
http://www.winehq.org/pipermail/wine-devel/2006-August/050139.html
http://www.winehq.org/pipermail/wine-devel/2006-August/050141.html.
memmove cannot be used because it provides other functionality - it doesn't suit LZ77
memcpy cannot be used because it's too clever (copies INTs instead of BYTEs), so doesn't suit LZ77
Solution: while (len--) *dst++=*src++; // The simplies way of memcpy
Any more suggestion of bad patch?
--HolyLich
More information about the wine-devel
mailing list