msi: remove limit on number of handles
Michael Stefaniuc
mstefani at redhat.com
Wed Aug 23 10:56:29 CDT 2006
Dan Kegel wrote:
> Changelog:
> msi: remove limit on number of handles
>
> handle.c | 30 +++++++++++++++++++++++-------
> msipriv.h | 1 -
> 2 files changed, 23 insertions(+), 8 deletions(-)
>
>
> ------------------------------------------------------------------------
>
> diff --git a/dlls/msi/handle.c b/dlls/msi/handle.c
> index 1cd82b3..79664f5 100644
> @@ -66,18 +67,29 @@ MSIHANDLE alloc_msihandle( MSIOBJECTHDR
>
> EnterCriticalSection( &MSI_handle_cs );
>
> + if (msihandletable == NULL)
> + {
> + /* start table off small to avoid hiding resize bugs */
> + msihandletable_size = 1;
Isn't this very small start value something to be used only for
debugging while one writes the resizing code? For "production" I would
use a value that is big enough to handle the common case (handles at
least 50% of the real life cases). As the old MSIMAXHANDLES was good
enough for a whole lot of programs i would define that as common case to
save me work of finding what the common case is.
> + msihandletable = msi_alloc_zero(1*sizeof(msi_handle_info));
> + }
> +
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Sr. Network Engineer Fax.: +49-711-96437-111
Red Hat GmbH Email: mstefani at redhat.com
Hauptstaetterstr. 58 http://www.redhat.de/
D-70178 Stuttgart
More information about the wine-devel
mailing list