DDraw: Protect IDirectDrawImpl against race conditions

Alexandre Julliard julliard at winehq.org
Thu Dec 7 14:17:29 CST 2006


Stefan Dösinger <stefandoesinger at gmx.at> writes:

> @@ -356,6 +373,8 @@ IDirectDrawImpl_SetupFullscreenWindow(ID
>   * Helper function that restores a windows' properties when taking it out
>   * of fullscreen mode
>   *
> + * Assumes that the critical section is properly held
> + *

This seems dangerous, changing the window size will potentially send
messages to other threads, so doing it inside the lock can cause
deadlocks.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list