Resend: user32: fix return value in DialogBoxParamA if no resourcecan be found + simple test (try 2)

Dmitry Timoshkov dmitry at codeweavers.com
Sun Dec 31 11:46:57 CST 2006


"Louis. Lenders" <xerox_xerox2000 at yahoo.co.uk> wrote:

> As Dmitry Timoshkov (thanks for that) the SetLastError was not necessary.
> Here's updated patch.

Probably the problem is that you need also handle both FindResourceW and
LoadResource failures the same way by returning -1, and change 'return -1;'
later to 'return 0;' (for invalid parent) as MSDN suggests. All that needs
to be tested as well. Also DialogBoxParamW needs to be fixed as well.

Probably other dialaog APIs (like DialogBoxIndirectParamAorW) need a review
regarding that.

-- 
Dmitry.




More information about the wine-devel mailing list